Fix the bash conditional for checking system architecture #12815
Conversation
The previous conditional exited with RC=2 when either
of the files were missing ('arch' is reported to be missing
on older kernels). This resulted in:
- false positive when the check was negated
- error messages on stderr
The proposed change moves the conditional into a Jinja macro.
|
Hi @mpurg. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
@jan-cerny could you have a look please, the PR relates to #12793 |
|
Code Climate has analyzed commit f941679 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.8% (0.0% change). View more on Code Climate. |
|
@jan-cerny I pushed the fix for the quotes |
Description:
Rationale:
The previous conditional exited with RC=2 when either of the files were missing ('arch' is reported to be missing on older kernels). This resulted in: